This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Fix for #129 (prefetch_related foreign_key-related object with queryset) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is for Django 1.8.x. This should be easily adaptable to work with Django 1.9+, too: See get_prefetch_queryset() in django.db.models.field.related_descriptors.ForwardManyToOneDescriptor.
maennel
reviewed
Feb 9, 2017
| # related_field = self.field.foreign_related_fields[0] | ||
| related_field = namedtuple('VersionedRelatedFieldTuple', 'name')('identity') | ||
|
|
||
| # FIXME: This will need to be revisited when we introduce support for |
There was a problem hiding this comment.
Should we take over this comment or rather make a reference to the relative place in the Django base: https://github.com/django/django/blob/1.8/django/db/models/fields/related.py#L560 ?
Since, basically, this has not much to do with CleanerVersion itself, since "just" monkey-patching.
There was a problem hiding this comment.
My (perhaps misguided) reasoning was that if the logic in the parent classes code changes at some point, it will be easier to see the differences and figure out what needs to be changed if this code is as similar as possible.
There was a problem hiding this comment.
Ok, fine for me. Let's go ahead...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is for Django 1.8.x.
This should be easily adaptable to work with Django 1.9+, too:
See get_prefetch_queryset() in
django.db.models.field.related_descriptors.ForwardManyToOneDescriptor.