fix(body-cell): set title on cell when not using cell template #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows the full value on hover by using the HTML title attribute. Since the content of the cell can get cut off with ellipsis, it is needed for the user to see the entire content.
rsparrow
pushed a commit
to rsparrow/ngx-datatable
that referenced
this pull request
Jun 2, 2017
fix(body-cell): set title on cell when not using cell template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows the full value on hover by using the HTML title attribute. Since the content of the cell can get cut off with ellipsis, it is needed for the user to see the entire content.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
You cannot see the entire content of a cell if it is too long and cut of with '...'
What is the new behavior?
You can now see the entire content by hovering over it. It will show up in the browser title hover.
Does this PR introduce a breaking change? (check one with "x")