Fix for release build where the operators are treeshaken away. #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amcdnl Sorry for introducing it in the first place! |
rsparrow
pushed a commit
to rsparrow/ngx-datatable
that referenced
this pull request
Jun 2, 2017
…tors Fix for release build where the operators are treeshaken away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
When using the released build and clicking the Datatable headers, there are javascript errors saying the 'do'-operator is not a function on observables.
Was introduced with my previous performance change, sorry!
What is the new behavior?
There is no exception when a user clicks the header.
I've removed the 'do' operator, and added an import to the takeUntil operator to be sure release builds will have the right operators imported
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: