Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for selected #314

Merged
merged 1 commit into from
Nov 26, 2016
Merged

Conversation

ghetolay
Copy link
Contributor

@ghetolay ghetolay commented Nov 23, 2016

What kind of change does this PR introduce? (check one with "x")

  • [X ] Bugfix

What is the current behavior?

Selection ins't working because selected property of DataTableComponent is not initialise, then that property is passed down to DatatableBodyComponent and DatatableSelectionComponent through @Input(). So even if both DatatableBodyComponent and DatatableSelectionComponent have an initial value for selected it gets overridden.

What is the new behavior?
It works !

Does this PR introduce a breaking change?

  • Yes
  • No

Again, I've done that directly on github, tell if you want me to clone and build it.

@amcdnl amcdnl merged commit 56e2bb2 into swimlane:master Nov 26, 2016
@amcdnl
Copy link
Contributor

amcdnl commented Nov 26, 2016

@ocombe - didn't u fix this?

Thanks for your pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants