Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Fixed bugs in Row Detail feature when virtual scrolling is not set #212

Merged
merged 1 commit into from
Oct 18, 2016
Merged

(fix): Fixed bugs in Row Detail feature when virtual scrolling is not set #212

merged 1 commit into from
Oct 18, 2016

Conversation

java2kus
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#210

What is the new behavior?

Row height cache is only initialized when virtual scrolling is enabled. In all other scenarios row calculations are automatically done. Also takes this takes care of the bug mentioned in pull request #208.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…t present.

@amcdnl amcdnl merged commit ef9156a into swimlane:master Oct 18, 2016
@amcdnl
Copy link
Contributor

amcdnl commented Oct 18, 2016

Awesome!

@java2kus java2kus deleted the data-table-detail-row-fix branch October 23, 2016 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants