Make directive AOT Compatible #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the way inputs are declared to make the directive AOT Compatible
Add the TS file for AOT
Add the needed packages to the package.json for AOT
I realized that the option for skipMetadataEmit should be false so it will make the require metadata.json files.
|
@amcdnl please merge this asap AoT is really must have feature! Thanks |
|
Do know this makes the code compile with AOT but I have not figured out how to make the compiled ngc AOT code bundle into the existing task chain. I was hoping @amcdnl could help there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Does not compile in AOT
What is the new behavior?
Compiles in AOT
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Change the way inputs are declared to make the directive AOT Compatible