Removed package.json engine restrictions #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the engine restrictions to prevent people from downloading it with Node 4.x and it having build errors. |
|
you only have build errors if you clone it from github and try to run it, not if you install it from npm right ? |
|
Correct. |
|
Then the engine restriction in the package.json doesn't help, because it only works when you npm install it from npm :) |
|
Thanks! :) |
|
I'm using node v6.3.1 and I still get this error using yarn, is this intended? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
The lib restricts the engine to node ~6.0.0 for no reason (this lib doesn't use any binary). This is a problem when using Yarn because it is more strict than npm and it will respect the engine restrictions which will fail the installation of all the npm modules with the following error message:
error angular2-data-table@0.9.3: The engine "node" is incompatible with this module. Expected version "~6.0.0".What is the new behavior?
Removed the restriction
Does this PR introduce a breaking change?