Migrate project to angular-cli #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisb90
reviewed
Sep 3, 2019
luisb90
reviewed
Sep 3, 2019
projects/swimlane/ngx-datatable/src/lib/components/body/body.component.ts
Outdated
Show resolved
Hide resolved
luisb90
reviewed
Sep 3, 2019
projects/swimlane/ngx-datatable/src/lib/components/datatable.component.ts
Show resolved
Hide resolved
luisb90
reviewed
Sep 3, 2019
projects/swimlane/ngx-datatable/src/lib/components/header/header.component.ts
Show resolved
Hide resolved
duredhel13
approved these changes
Sep 3, 2019
|
found a disparity issue while running through the demos.
|
|
Fixed - needed to update the style in that demo. |
luisb90
approved these changes
Sep 4, 2019
|
Are you sure it works now?
|
even on wannabebrowser (I.E. 9) seems fine to me... |
What are you testing on? This is what I see:
|
|
I usually use Chrome and it's ok there, but this was on Safari. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the new behavior?
Migrates the project to angular-cli
Builds using ng-packagr
Ivy compatible
Removes the compiled files from the git repository
Reformats the whole codebase
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: