Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when count is undefined #1499

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Fix issue when count is undefined #1499

merged 1 commit into from
Jul 27, 2018

Conversation

yociduo
Copy link
Contributor

@yociduo yociduo commented Jul 26, 2018

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Throw exception

What is the new behavior?

Handle exception

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@yociduo
Copy link
Contributor Author

yociduo commented Jul 26, 2018

#838 relate with the issue

@marjan-georgiev
Copy link
Member

@yociduo thank you for the contribution. Could you revert the changes to the release folder please? Otherwise this looks good to me.

@yociduo
Copy link
Contributor Author

yociduo commented Jul 27, 2018

@marjan-georgiev OK, reset those files

@marjan-georgiev marjan-georgiev merged commit 646e44a into swimlane:master Jul 27, 2018
@marjan-georgiev
Copy link
Member

Merged, thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants