Fix usage withing prerendered SPA #1438
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure not to crash on the absence of a window object
|
Can this be merged and released soon? |
|
@marjan-georgiev Really need this |
|
@marjan-georgiev Are there any stoppers to merge this? |
|
No, looks good. Thanks for the contribution @GrimaceOfDespair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure not to crash on the absence of a window object
What kind of change does this PR introduce? (check one with "x")
What is the current behavior?
Using ngx-datatable in the context of a prerendered application crashes as described in #1396
What is the new behavior?
ngx-datatable can be used in a prerendered application without crashing.
Does this PR introduce a breaking change? (check one with "x")
Other information: