Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): angular version #1420

Merged
merged 1 commit into from
May 17, 2018

Conversation

osnoser1
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Does not accept patch versions or minor versions of angular 6 as peer dependency.

What is the new behavior?

The Angular version must be less than 7.0.0.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

fixes #1413

Copy link

@dgerritsen dgerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to remove the "=" equal operator, unless you're absolutely sure it works with Angular 7. Since there hasn't been any ng7 release, it would be better not to allow v7.0.0 yet.

@osnoser1
Copy link
Contributor Author

Done! 😃

@marjan-georgiev marjan-georgiev merged commit f278f4e into swimlane:master May 17, 2018
@marjan-georgiev
Copy link
Member

Thanks!

@osnoser1 osnoser1 deleted the bugfix/angular-version branch May 17, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Angular 6.0.1
3 participants