Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1296 npm run build --prod #1410

Merged
merged 2 commits into from
May 22, 2018

Conversation

stefanosalad
Copy link
Contributor

@stefanosalad stefanosalad commented May 10, 2018

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
ng build --prod fails as described in the issue #1240 and #1296

What is the new behavior?

  • removed an unused function parameter
  • removed incompatible object parameter

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@marjan-georgiev marjan-georgiev merged commit 1d3ea40 into swimlane:master May 22, 2018
@marjan-georgiev
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants