Improve virtualization as a flag. The original idea is be able to configure paging and scrolling without virtualization #1297
Conversation
|
Hello, I have several months working with these changes and they are working correctly, you could have an eye here, please? 😪 |
|
Works like a charm, please merge this PR. I need this feature and currently I am forced to work with a fork to have this feature (see https://github.com/XITASO/ngx-datatable/tree/merge_pr_1297) |
… been used in the scroll mechanism. In the real world this property comes from datatable component as @input parameter
|
Hello, please is it possible to have this PR merged in near future? Thank you |
|
Looks good. Thank you @lneninger 👍 |
…figure paging and scrolling without virtualization (swimlane#1297) * Improve core. Adding virtualization flag at scrollbarV conditions * Fixing Conflicts with master branch * Fixing test. The test doesn't define virtualization property whith is been used in the scroll mechanism. In the real world this property comes from datatable component as @input parameter * Removing debugger keyword from test # Conflicts: # demo/paging/scrolling-server.component.ts # src/components/body/body.component.spec.ts
|
IMO |
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The vertical scroll feature [scrollbarV]="true" is assuming that virtualization is active. So, when is desired to have external pagination with scrolling and no virtualization the table mechanism try the scrolling as a paging event and force the current page.
What is the new behavior?
With external pagination and scrollbarV and no virtualization the data-table mechanism trigger the paging event on event onFooterPage only avoiding the undesired behavior of auto paging back to first page after select a page on the pagination component; which is the desired behavior. The original behavior for scrollbarV with virtualization remains the same as well as paging without scrolling.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: