Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rowHeight type in body component #1295

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Fix rowHeight type in body component #1295

merged 2 commits into from
Apr 16, 2018

Conversation

laxu
Copy link

@laxu laxu commented Feb 13, 2018

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Typescript error as in #1219.

What is the new behavior?
Fixes #1219 by adding the correct type for rowHeight input.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@amcdnl amcdnl merged commit 47de21b into swimlane:master Apr 16, 2018
@laxu laxu deleted the fix/rowHeight-type branch April 16, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants