Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pager Component Accessibility #1259

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Pager Component Accessibility #1259

merged 1 commit into from
Feb 9, 2018

Conversation

palashp
Copy link
Contributor

@palashp palashp commented Jan 26, 2018

Adding Labels and Roles for Accessibility

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Pagination options are not labelled and not marked up as buttons

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Adding Labels and Roles for Accessibility
@claire921
Copy link

@amcdnl

Can you please take a look at this PR? Thanks!

@amcdnl amcdnl merged commit fdb7775 into swimlane:master Feb 9, 2018
@amcdnl
Copy link
Contributor

amcdnl commented Feb 9, 2018

LGTM

@claire921
Copy link

@amcdnl Do you know when will this patch be included in a new release? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants