Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setStylesByGroup() in set column prop #1244

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

darkurse
Copy link

What kind of change does this PR introduce? (check one with "x")

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
Column headers are not being resized on initialization
image

Without any changes to the code, only a windows resize seems to resolve this issue.

What is the new behavior?
It re-calculates the style (width) of each groups "left", "center", "right" after the columns have been set via the column property in header.component.ts.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Other information:

Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcdnl amcdnl merged commit df11e84 into swimlane:master Jan 18, 2018
@stewx
Copy link
Contributor

stewx commented Mar 13, 2018

This change appears to have introduced a new defect: #1319

It is not immediately obvious why, but using Git bisect, I narrowed it down to this commit.

@stewx
Copy link
Contributor

stewx commented Mar 13, 2018

Can either of you offer insight? @amcdnl @darkurse

@stewx
Copy link
Contributor

stewx commented Mar 13, 2018

PR to fix the defect introduced here: #1326

This PR should have updated the logic for the body at the same time as it did for the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants