Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize handler for non-resizable columns #1225

Merged
merged 1 commit into from
Jan 14, 2018
Merged

Add resize handler for non-resizable columns #1225

merged 1 commit into from
Jan 14, 2018

Conversation

artemios-git
Copy link
Contributor

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
There is no resize handler element when column is not resizable, so we cannot apply the same styles like, fox example, border.

What is the new behavior?
Now there is also exists resize handler span element when column is no resizable. It has different CSS class so we can put some different styles to it

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@amcdnl
Copy link
Contributor

amcdnl commented Jan 11, 2018

I'm a bit confused on the purpose of this. You want to add a handle when there is no resize? Seems odd.

@artemios-git
Copy link
Contributor Author

artemios-git commented Jan 12, 2018

There is next situation http://joxi.ru/v29nlnKiGDaOKA first column is not re-sizable and other are re-sizable, for re-sizable columns we have span tag with "resize-handle" css class, and i can apply for example style of our border between columns such as white color, and when column is not re sizable we didn't have this span tag element and i need to make border in another way, and this is not consistent, i hope you understand what i'm talking about

@amcdnl
Copy link
Contributor

amcdnl commented Jan 14, 2018

Gotcha. Accepted! Thanks for your contribution!

@amcdnl amcdnl merged commit 70bac98 into swimlane:master Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants