Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cell overflow when height is not fixed #1030

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Conversation

wizarrc
Copy link
Contributor

@wizarrc wizarrc commented Oct 4, 2017

multiple-tables demo cells overflow on second table where [rowHeight]="'auto'"

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

css overflows outside cell when row height is not fixed and column width is too small to fix content.

What is the new behavior?

css overflow is hidden outside cell when row height is not fixed and column width is too small to fix content.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

overflow-x

[multiple-tables](http://swimlane.github.io/ngx-datatable/#multiple-tables) demo cells overflow on second table where `[rowHeight]="'auto'"`
@amcdnl amcdnl merged commit aeb30d0 into swimlane:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants