Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with server-side rendering #668

Closed
spiffyjr opened this issue Apr 7, 2017 · 2 comments
Closed

Incompatible with server-side rendering #668

spiffyjr opened this issue Apr 7, 2017 · 2 comments

Comments

@spiffyjr
Copy link

spiffyjr commented Apr 7, 2017 •
edited
Loading

I'm submitting a ... (check one with "x")

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here

Current behavior
Usage of document throughout the project breaks server-side rendering.

e.g., var testStyle = document.createElement('div').style;

Expected behavior
Server-side rendering to build.
amcdnl added a commit that referenced this issue Apr 8, 2017
@amcdnl
bug(universal): do not use document for universal rendering #668
1592b67
@amcdnl
Copy link
Contributor

amcdnl commented Apr 8, 2017

Pushed fixed, will be in next release.

@amcdnl amcdnl closed this as completed Apr 8, 2017
@spiffyjr
Copy link
Author

spiffyjr commented Apr 9, 2017

Excellent!

rsparrow pushed a commit to rsparrow/ngx-datatable that referenced this issue Jun 2, 2017
@amcdnl
bug(universal): do not use document for universal rendering swimlane#668
745c607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amcdnl @spiffyjr