Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML title attribute for column header should not be added when custom template is being used #643

Closed
arti040 opened this issue Mar 28, 2017 · 3 comments
Closed

HTML title attribute for column header should not be added when custom template is being used #643

arti040 opened this issue Mar 28, 2017 · 3 comments
Labels
Accepting PRs Bug Effort: Easy Priority: Low

Comments

@arti040
Copy link

arti040 commented Mar 28, 2017 •
edited
Loading

I'm submitting a ...

[ ] bug report => search github for a similar issue or PR before submitting
[X] feature request
[ ] support request => Please do not submit support request here

Current behavior
When you use ng2 template tag for column header, TITLE attribute is being added automatically.

Expected behavior
When you use ng2 template tag for column header, TITLE attribute shouldn't be added (or be configurable at least).

Reproduction of the problem
N-A.

What is the motivation / use case for changing the behavior?
This may confuse user, especially if any tooltip/popover plugin is being used within custom template.
Would be nice to have TITLE attribute in column headers configurable.

Please tell us about your environment:
N-A

  • Table version: 0.7.1.1

  • Angular version: 4.0

  • Browser:
    All

  • Language:
    ES6/7
@amcdnl
Copy link
Contributor

amcdnl commented Apr 10, 2017

Good call, can you PR?

@eddy-geek
Copy link

@litzebauer is your commit above ready for PR or is it WIP?

@litzebauer
Copy link

@eddy-geek It's ready for PR

@amcdnl amcdnl closed this as completed in abb1b8b Apr 24, 2017
amcdnl added a commit that referenced this issue Apr 24, 2017
@amcdnl
Merge pull request #693 from litzebauer/column-header-tile
ef87b73 
Don't add column header title attribute when custom template provided, Fixes #643
uejb pushed a commit to uejb/ngx-datatable that referenced this issue Apr 25, 2017
@uejb
Don't add header title if header template provided, fixes swimlane#643
f227aab
rsparrow pushed a commit to rsparrow/ngx-datatable that referenced this issue Jun 2, 2017
Don't add header title if header template provided, fixes swimlane#643
2ce2329
rsparrow pushed a commit to rsparrow/ngx-datatable that referenced this issue Jun 2, 2017
@amcdnl
Merge pull request swimlane#693 from litzebauer/column-header-tile
5ee8069 
Don't add column header title attribute when custom template provided, Fixes swimlane#643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Bug Effort: Easy Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amcdnl @litzebauer @eddy-geek @arti040