-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prop names with dots #596
Comments
If you do |
I am using columns array to set up columns as I need to provide those fromthe outside in order to create a generic grid list. That's why I haven't tested with template way of setting in columns. |
Sure, Arlowhite, I saw your PR but tnx for the notice. |
My PR was just merged. :) I will create a PR to fix this soon unless someone else says they're already working on it. |
@arlowhite - did you have a chance to make this PR yet? |
unit test deepValueGetter. fix #596 prop field name with dots.
unit test deepValueGetter. fix swimlane#596 prop field name with dots.
I'm submitting a ... (check one with "x")
Current behavior
When property names are with dot notation like from an elastic search :
"body.property.subproperty" the deep-getter fails to retrieve the value of the cell
Expected behavior
Deep-getter should have a check if obj[path] returns a value and if no then it can proceed in destructuring the path.
Reproduction of the problem
Provide an object with keys names in following format:
"main.property"
"main.property.subproperty"
What is the motivation / use case for changing the behavior?
when using the datatable with serverside Java elastic search
Please tell us about your environment:
os: win32 x64
6.3.0
@angular/cli: 1.0.0-rc.1
node: 6.9.2
@angular/common: 2.4.9
@angular/compiler: 2.4.9
@angular/core: 2.4.9
@angular/forms: 2.4.9
@angular/http: 2.4.9
@angular/platform-browser: 2.4.9
@angular/platform-browser-dynamic: 2.4.9
@angular/router: 3.4.9
@angular/cli: 1.0.0-rc.1
@angular/compiler-cli: 2.4.9
The text was updated successfully, but these errors were encountered: