[pull] swiftwasm from master #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…wiftlang#29294) correctly there. To do this just disable on Linux where the test is currently broken. rdar://problem/58640751
…volving generic functions
…ster-rebranch. Bumping the module version just in case.
Since resilient class metadata is built at runtime, we don't actually care if there are missing vtable entries. The restriction was relaxed in Sema in 9117c57, but SILGen still had an assertion here. Add a test and relax the assertion. Fixes <rdar://problem/58644615>.
Merge master-rebranch into master to support new llvm branch apple/stable/20200108
…backtrace.swift [test] Fix LLDB Python Path and re-enable linux-fatal-backtrace.swift
…-assertion SILGen: Relax assertion about missing vtable entries in a class
…arameters-errors [Diagnostics] Remove `FailureDiagnosis::diagnoseParameterErrors` from CSDiag
…en returning from a void function (swiftlang#29747) * [CSDiagnostics] Offer a fix-it to insert a return type when returning from a void function * [CSDiagnostics] Make sure the function name is not empty The function name will be empty in some cases, for example for property setters. In cases where the function name is empty, skip the note and fix-it. * [Test] Update existing diagnostics
…ripts [NFC][Python: black] Reformatted the benchmark Python sources using utils/python_format.py.
|
@kateinoigakukun now seeing some conflicts here, what do you think is the best way to resolve those? |
|
@MaxDesiatov Umm, I think these conflicts are caused by "squash and merge" 🤔 Could you force push |
|
@MaxDesiatov Thanks 😄 Conflicts are gone now! |
|
CI is not triggered 🤔 I'll close this PR temporarily |
MaxDesiatov
pushed a commit
that referenced
this pull request
Feb 13, 2020
[pull] swiftwasm from apple:master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )