Skip to content

Commit

Permalink
SR-15237 Fix typelayout_based_value_witness.swift
Browse files Browse the repository at this point in the history
typelayout_based_value_witness.swift failed on iphoneos-arm64e due to an extra
line of IR that gets generated. That meant the swift_release line had '#7'
instead of '#6'. The test shouldn't be checking for '#6' anyways, so removed
that check which causes the test to now pass.
  • Loading branch information
gmittert committed Sep 23, 2021
1 parent 12a2e20 commit 43b5b5f
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions test/IRGen/typelayout_based_value_witness.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
// RUN: %target-swift-frontend -enable-type-layout -force-struct-type-layouts -primary-file %s -O -emit-ir | %FileCheck %s --check-prefix=FORCE-OPT --check-prefix=FORCE-OPT-%target-ptrsize
// RUN: %target-swift-frontend -primary-file %s -emit-ir | %FileCheck %s --check-prefix=NOTL

// https://bugs.swift.org/browse/SR-15237
// UNSUPPORTED: CPU=arm64e

public struct B<T> {
var x: T
var y: T
Expand Down Expand Up @@ -130,7 +127,7 @@ public enum ForwardEnum<T> {
// FORCE-OPT: [[CASTED:%.*]] = bitcast i8* [[OFFSET]] to %T30typelayout_based_value_witness1CC**
// FORCE-OPT: %toDestroy = load %T30typelayout_based_value_witness1CC*, %T30typelayout_based_value_witness1CC** [[CASTED]]
// FORCE-OPT: [[FIELD:%.*]] = getelementptr %T30typelayout_based_value_witness1CC, %T30typelayout_based_value_witness1CC* %toDestroy, {{(i64|i32)}} 0, i32 0
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]]) #6
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]])
// FORCE-OPT: ret void
// FORCE-OPT:}

Expand All @@ -151,7 +148,7 @@ public enum ForwardEnum<T> {
// FORCE-OPT: [[CASTED:%.*]] = bitcast i8* [[OFFSET]] to %T30typelayout_based_value_witness1CC**
// FORCE-OPT: %toDestroy = load %T30typelayout_based_value_witness1CC*, %T30typelayout_based_value_witness1CC** [[CASTED]]
// FORCE-OPT: [[FIELD:%.*]] = getelementptr %T30typelayout_based_value_witness1CC, %T30typelayout_based_value_witness1CC* %toDestroy, {{(i64|i32)}} 0, i32 0
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]]) #6
// FORCE-OPT: tail call void @swift_release(%swift.refcounted* [[FIELD]])
// FORCE-OPT: ret void
// FORCE-OPT:}

Expand Down

0 comments on commit 43b5b5f

Please sign in to comment.