Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default toolchain version to 5.8 channel snapshot #398

Merged
merged 3 commits into from
May 8, 2023

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented May 4, 2023

SwiftPM 5.8 changed package init template to omit the target directory by default for --type executable:

5.7

$ /home/katei/.carton/sdk/wasm-5.7.1-RELEASE/usr/bin/swift package init --type executable --name Foo
Creating executable package: Foo
Creating Package.swift
Creating README.md
Creating .gitignore
Creating Sources/
Creating Sources/Foo/Foo.swift
Creating Tests/
Creating Tests/FooTests/
Creating Tests/FooTests/FooTests.swift
$ tree
.
├── Package.swift
├── README.md
├── Sources
│   └── Foo
│       └── Foo.swift
└── Tests
    └── FooTests
        └── FooTests.swift

4 directories, 4 files

5.8

$ /home/katei/.carton/sdk/wasm-5.8-SNAPSHOT-2023-04-30-a/usr/bin/swift package init --name Foo --type executable
Creating executable package: Foo
Creating Package.swift
Creating .gitignore
Creating Sources/
Creating Sources/main.swift
$ tree
.
├── Package.swift
└── Sources
    └── main.swift

Therefore, changed the underlying init command to --type library and add executable target by carton.
Also added a workaround for swiftwasm/swift#5375

@kateinoigakukun kateinoigakukun marked this pull request as draft May 4, 2023 10:45
@kateinoigakukun kateinoigakukun added the enhancement New feature or request label May 4, 2023
@kateinoigakukun kateinoigakukun changed the title [DNM] Update default toolchain version to 5.8 channel snapshot Update default toolchain version to 5.8 channel snapshot May 8, 2023
@kateinoigakukun kateinoigakukun marked this pull request as ready for review May 8, 2023 00:32
@kateinoigakukun kateinoigakukun requested a review from a team May 8, 2023 00:32
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented May 8, 2023

@swiftwasm/carton-team Could you have a quick look before merging? This blocks releasing swiftwasm-action. Thanks

@kateinoigakukun
Copy link
Member Author

Thank you @yonihemi 😍

@kateinoigakukun kateinoigakukun merged commit a19e1ac into main May 8, 2023
@kateinoigakukun kateinoigakukun deleted the katei/default-toolchain-5.8 branch May 8, 2023 12:00
@yonihemi
Copy link
Member

yonihemi commented May 8, 2023

Thanks for pushing this release through, amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants