Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up adjustment for Embedded support #265

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Follow-up adjustment for Embedded support #265

merged 4 commits into from
Oct 15, 2024

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 15, 2024 •
edited
Loading

Follow-up for #263

@kateinoigakukun
Fix build for embedded platforms around JSBigIntExtended existential
0dbd39a
@kateinoigakukun
Simplify the embedded example
a4636bb 
* Remove EmbeddedFoundation dependency
* Prefix the experimental feature flags with `JAVASCRIPTKIT_`
* Remove the unnecessary C shim for `memmove`, which is now provided by `swift-dlmalloc`
* Add the `arc4random_buf` shim for the latest Hashable support
@kateinoigakukun
Unify JavaScriptValueKindAndFlags type across non-/Embedded builds
17af647
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Time Change: +225ms (2%)

Total Time: 9,782ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 20ms -1ms (5%) ✅
Serialization/JavaScript function call from Swift 110ms +6ms (5%) 🔍
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 15ms -0ms
Serialization/Swift Int to JavaScript with assignment 329ms +8ms (2%)
Serialization/Swift Int to JavaScript with call 1,045ms +48ms (4%)
Serialization/JavaScript Number to Swift Int 313ms +15ms (4%)
Serialization/Swift String to JavaScript with assignment 382ms +2ms (0%)
Serialization/Swift String to JavaScript with call 1,103ms +37ms (3%)
Serialization/JavaScript String to Swift String 3,774ms +97ms (2%)
Object heap/Increment and decrement RC 2,680ms +13ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 2ms

@kateinoigakukun kateinoigakukun force-pushed the katei/embedded-followup branch from bb84a4f to c326ebf Compare October 15, 2024 02:54
@kateinoigakukun kateinoigakukun merged commit b78f3ca into main Oct 15, 2024
17 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/embedded-followup branch October 15, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kateinoigakukun