#21 - Config loader changes, refactoring and cleanup #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change here is how config files are loaded. I switched from using
__DIR__to$_SERVER['SCRIPT_FILENAME'], because the former resolves symlinks, while the latter doesn't. Also, I removed some unnecessary paths form the output of paths collector, as they were not inline with README file.Now when we run
vendor/bin/driverorvendor/swiftottter/driver/bin/driverfrom project root, we are getting project root and vendor subdirectories (no matter ifvendor/swiftottter/driveris symlink or not).And when we run
bin/driverfrom Driver root, we are getting Driver root.I also performed some cleanup / refactoring.