Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extension activation for insiders build #1073

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix extension activation for insiders build #1073

merged 1 commit into from
Sep 16, 2024

Conversation

award999
Copy link
Contributor

  • VSCode has moved node-pty out of the asar bundle and into a typical node_modules folder structure
  • If old way fails, fall back on new insiders path

@award999
Fix extension activation for inisders build
7edb2a2 
* VSCode has moved node-pty out of the asar bundle and into a typical
  node_modules folder structure
@plemarquand plemarquand changed the title Fix extension activation for inisders build Fix extension activation for insiders build Sep 16, 2024
@plemarquand plemarquand merged commit be8372e into swiftlang:main Sep 16, 2024
8 checks passed
@award999 award999 deleted the node-pty branch September 20, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plemarquand plemarquand plemarquand approved these changes

@matthewbastien matthewbastien matthewbastien approved these changes

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@award999 @plemarquand @matthewbastien