[6.0] Rename ExtensionImportVisibility to MemberImportVisibility and fix bugs #73094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature controls lookup behavior for members in general, not just extension members. Resolves rdar://126491324
- Reorganize test cases - Add tests cases for multi-file and contextual base lookup - Verify behavior without `MemberImportVisibility` feature NFC.
Make sure suggested imports are consistent with imports in other files. Also, make sure the underlying clang module is always imported `@_exported`.
This results in clearer source locations for diagnostics.
tshortli
added
🍒 release cherry pick
|
@swift-ci please test |
nkcsgexi
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensionImportVisibilityexperimental feature toMemberImportVisibility. Although extension members are the members that are most often accidentally visible via transitive imports, the effects of enabling the feature are not limited to lookup of members on extensions. The test cases added in this PR provide examples of additional situations where these diagnostics will take effect. Also fixes some important bugs in the implementation of the feature.-enable-experimental-feature MemberImportVisibility. These changes are proposed for inclusion in Swift 6.0 to facilitate evaluation of the feature's behavior for an upcoming language mode.MemberImportVisibilityfeature.MemberImportVisibilityto evaluate the real world impact of the feature.