stdlib: Adopt ExtensionImportVisibility experimental feature
#72871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This didn't expose any missing imports in the sources of any of the standard library modules, but that's not entirely surprising. Still, we should have the feature enabled to test it and prevent regressions from creeping in before the behavior becomes the default. Exclude `ExtensionImportVisibility` from module interfaces.
|
@swift-ci please smoke test |
DougGregor
approved these changes
Apr 5, 2024
| @@ -367,7 +367,7 @@ CONDITIONALLY_SUPPRESSIBLE_EXPERIMENTAL_FEATURE(IsolatedAny, true) | |||
|
|
|||
|
|
|||
| // Whether members of extensions respect the enclosing file's imports. | |||
| EXPERIMENTAL_FEATURE(ExtensionImportVisibility, true) | |||
| EXPERIMENTAL_FEATURE_EXCLUDED_FROM_MODULE_INTERFACE(ExtensionImportVisibility, true) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the
ExtensionImportVisibilityfeature when building the all standard library modules so that we're dogfooding the feature. Not very surprisingly, given their low dependency footprint, this has no effect on the sources of any of the stdlib modules.Also, round out the test coverage for
ExtensionImportVisibilityby adding Obj-C interop tests and specifically testingAnyObjectlookup. It turns out thatAnyObjectalready filters out extension/category members that were not directly imported so the flag has no effect on it. We could potentially improve the diagnostics forAnyObjectlookup misses that could be fixed by adding an import but that seems like a nice-to-have improvement we can do later.