[5.7][Driver] Work around lld 13+ issue with --gc-sections for ELF by adding -z nostart-stop-gc #60653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng -z nostart-stop-gc (swiftlang#60544) Fixes swiftlang#60406 Ran the linux x86_64 compiler validation suite on this pull with `-use-ld=lld -Xlinker --gc-sections`, then without stripping as in the linked issue, and only saw the 20 unrelated failures just like @drodriguez had.
|
@swift-ci test |
compnerd
approved these changes
Aug 19, 2022
|
@swift-ci please test Linux platform |
This was referenced Aug 19, 2022
DougGregor
approved these changes
Aug 23, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #60544
Explanation: lld 13 changed how
--gc-sectionsworks last year, which was then flipped on by default, and causes all Swift code on ELF platforms not to link with lld 13 and 14 anymore if stripping is enabled.Scope: Only affects lld for these ELF platforms
SR Issue: #60406
Risk: low, since it only affects ELF platforms for this one linker
Testing: I just built the last August 2 source snapshot of the 5.7 toolchain for Android AArch64, where lld 14 is the default linker, with this patch and it works well.
Reviewer: @compnerd