[AnyHashable] Eliminate the _AnyHashableProtocol hack. #5132
+8
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have the ability to write extensions where one of the type parameters is equivalent to a concrete type, eliminate _AnyHashableProtocol and provide AnyHashable-specific behavior for Dictionary (where Key == AnyHashable) and Set (where Element == AnyHashable) rather than employing the "Key: _AnyHashableProtocol" hack. Fixes standard library ABI FIXME's swiftlang#35, swiftlang#37, swiftlang#39.
|
@swift-ci please smoke test and merge |
|
Looks like this exposed a SIL printer bug... oops |
|
@slavapestov , are you planning to look into the SIL printer issue? |
|
I can take a look, sure. I think I know what it is. |
|
It's printing out a generic signature: Which is valid but very much not what we want ;) |
|
@DougGregor Yeah, the SIL printer wants to map type parameters to archetypes for some reason, I think to recover names because it starts with canonical type parameters. I've wanted to refactor this, to fix this very issue. Surprised it hasn't come up before. |
|
Fix is still not quite done, but it's coming along: slavapestov@3e031ff |
|
Hi Doug, I rebased this and merged it as part of #5266. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the ability to write extensions where one of the type
parameters is equivalent to a concrete type, eliminate
_AnyHashableProtocoland provideAnyHashable-specific behavior forDictionary(whereKey == AnyHashable) andSet(where Element == AnyHashable) rather than employing theKey: _AnyHashableProtocolhack.
Fixes standard library ABI FIXME's #35, #37, #39.