Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] test PR for SwiftPM feature #41374

Closed
wants to merge 1 commit into from
Closed

[DNM] test PR for SwiftPM feature #41374

wants to merge 1 commit into from

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Feb 14, 2022

@tomerd
Copy link
Contributor Author

tomerd commented Feb 14, 2022

@tomerd
Copy link
Contributor Author

tomerd commented Feb 14, 2022

@swift-ci test Windows

@tomerd
Copy link
Contributor Author

tomerd commented Feb 14, 2022

swiftlang/swift-package-manager#4135

@swift-ci please test windows

@compnerd
Copy link
Member

I don't think that this works as expected - this is not going to trigger the actual desired build - which is the toolchain build and test: https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/

This is going to trigger the toolchain build: https://ci-external.swift.org/job/oss-swift-windows-x86_64-vs2019/

@tomerd
Copy link
Contributor Author

tomerd commented Feb 14, 2022

@tomerd
Copy link
Contributor Author

tomerd commented Feb 15, 2022

@compnerd is this a good enough test to merge swiftlang/swift-package-manager#4135?

@compnerd
Copy link
Member

Afraid that this doesn't actually exercise the SPM path - so this doesn't work; I can try to run it locally (or if @shahmishal can setup a trigger for https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/ that might work)

@tomerd
Copy link
Contributor Author

tomerd commented Feb 15, 2022

thanks @compnerd would be nice to have a CI that can help us test such things on Windows. could you loop back on swiftlang/swift-package-manager#4135 when you have results?

@tomerd tomerd closed this Feb 18, 2022
@tomerd tomerd deleted the tomerd-patch-4 branch March 17, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants