SE-0309: Unlock existential types for all protocols #39095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… educational note
|
@swift-ci please test |
|
Build failed |
…rtedProtocolType()
…colSelfReferences»
…xistential member access
…inside collections, since the optimizer doesn't know how to handle them yet
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux |
theblixguy
added
the
swift evolution approved
ktoso
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
LGTM and let's hunt down the issue introduced in #34140 separately. (more info in: #33767 (comment) )
CodaFi
reviewed
Oct 6, 2021
| @@ -1257,7 +1257,6 @@ namespace decls_block { | |||
| BCFixed<1>, // implicit flag | |||
| BCFixed<1>, // class-bounded? | |||
| BCFixed<1>, // objc? | |||
| BCFixed<1>, // existential-type-supported? | |||
There was a problem hiding this comment.
Don't forget to bump the format version.
There was a problem hiding this comment.
Oops. Does it still need to be (has been incremented 6 times since this landed)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.