[SR-12955] [Sema] Don't diagnose invalid conversion if fnType has error #32337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPAlmeida
force-pushed
the
SR-12955-avoid-error-type-diag
branch
from
3273e0f
to
0c33206
Compare
|
Nice, thanks! I'm not entirely qualified to review the changes but I don't see anything horribly wrong. |
CodaFi
approved these changes
Jun 12, 2020
|
@swift-ci smoke test |
xedin
approved these changes
Jun 12, 2020
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid diagnosing ObjectiveC non-convertible if the function type has an error.
cc @mikeash
Resolves SR-12955.