Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MandatoryInlining: fix a memory lifetime bug related to partial_apply with in_guaranteed parameters. #32317

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

eeckstein
Copy link
Contributor

Because partial_apply consumes it's arguments we need to copy them. This was done for "direct" parameters but not for address parameters.

rdar://problem/64035105

… with in_guaranteed parameters.

Because partial_apply consumes it's arguments we need to copy them. This was done for "direct" parameters but not for address parameters.

rdar://problem/64035105
@eeckstein eeckstein requested a review from gottesmm June 11, 2020 16:57
@eeckstein
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - acf923b

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test macOS

@eeckstein eeckstein merged commit 7784581 into swiftlang:master Jun 12, 2020
@eeckstein eeckstein deleted the fix-mandatory-inliner branch June 12, 2020 09:06
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants