Simplify obtaining of swift sources #31

BrandonMathis · 2015-12-03T17:42:19Z

With hopes of making the install/obtaining of sources process easier. I have collapses all github repo clone commands into a utils/clone_resources.sh command which can be run via a curl command.

Readme updated as well

kylef · 2015-12-03T17:43:23Z

utils/clone_resources.sh

@@ -0,0 +1,11 @@
+#!/usr/env bash
+
+git clone git@github.com:apple/swift.git swift


If the Swift team goes ahead with this approach, please can #29 be changed here too.

XBeg9 · 2015-12-03T17:48:40Z

+1

stuarthannig · 2015-12-03T17:49:24Z

This may need to be taken into consideration as well.

#29

BrandonMathis · 2015-12-03T17:49:56Z

TY @stuarthannig Change has been made.

Leandros · 2015-12-03T18:03:43Z

http://curlpipesh.tumblr.com/

BrandonMathis · 2015-12-03T18:17:32Z

Hmmm, that would require the installation of quick-secure on users machines, right @Leandros?

jetpacmonkey · 2015-12-03T18:29:06Z

He's not recommending the use of quick-secure, he's calling out the bad practice of piping curl to sh.

jsjohnst · 2015-12-03T18:51:28Z

👎 * 💯

No offense to @BrandonMathis, but folks who write documentation that tells users to curl pipe into bash need to stop writing documentation until they learn why that is a severe anti-pattern that needs to die.

davidcelis · 2015-12-03T19:26:07Z

Agreed. If anything, couldn't utils/build-script take responsibility for cloning down the dependencies that swift needs to build?

Leandros · 2015-12-03T19:50:32Z

He's not recommending the use of quick-secure, he's calling out the bad practice of piping curl to sh.

Exactly.

LinusU · 2015-12-03T21:12:30Z

👎 * 💯

No offense to @BrandonMathis, but folks who write documentation that tells users to curl pipe into bash need to stop writing documentation until they learn why that is a severe anti-pattern that needs to die.

Yes a thousand times! There is nothing worse than seeing that in documentation.

rootedbox · 2015-12-03T21:33:58Z

complicates maintenance, and less secure.

BrandonMathis · 2015-12-03T22:28:19Z

Ah Thanks @jetpacmonkey & @jsjohnst that is a pretty good point. Running arbitrary code from a curl command would be very off-putting to many developers!

I do like @davidcelis' suggestion of moving this functionality into utils/build-script but that script seems to server a very specific and single purpose. Perhaps the Readme should just be updated to advise that the utils/clone_repos.sh script locally? That would also greatly simplify maintenance and you would not run the risk of executing a script from remote that may have diverged from what you have cloned locally on your machine.

gribozavr · 2015-12-03T22:32:37Z

I would prefer the VCS-related functionality to be separate from the build-script. The build script is being executed in automated environments, like CI and build machines, that need to reliably build a given source tree, so it shouldn't have the functionality to download sources from the network.

utils/update-checkout --clone seems the right place for this.

yurikoles · 2015-12-03T22:36:57Z

@BrandonMathis, you are on par with @AndreasPrang on commits quantity that you need to fix URL.
Keep going and you will bit him.

BrandonMathis · 2015-12-03T22:48:42Z

Agreed, thx for the suggestion @gribozavr

wadestuart · 2015-12-03T23:20:48Z

@Leandros It may make sense to actually provide a curlsh line to drive awareness, the script could be as simple as:

#!/bin/sh
echo "Stop executing random commands you find on the internet.  You could have been owned."

BrandonMathis · 2015-12-03T23:38:33Z

@gribozavr, Moved this into utils/update-checkout --clone. Should settle the security concerns the community has 😄

Thanks for the help all! Excited to see what the future of swift will hold.

📝 Merging this will also close:

jsjohnst · 2015-12-03T23:44:57Z

I'm not sure if --clone makes sense being allowed to be with the other options. I think it would make more sense if it was something like

if args.clone:
   # do clone
else:
   # do existing functionality

gribozavr · 2015-12-03T23:46:32Z

README.md

-     git clone git@github.com:apple/swift-corelibs-xctest.git
-     git clone git@github.com:apple/swift-corelibs-foundation.git
-
+     ./utils/update-checkout --clone


One still needs to clone the swift repo, and then cd into it.

jsjohnst · 2015-12-03T23:51:54Z

Great catches @gribozavr!

rootedbox · 2015-12-03T23:55:09Z

utils/update-checkout

@@ -52,6 +53,21 @@ def update_working_copy(repo_path):
        else:
            check_call([ "svn", "update" ])

+def obtain_additional_swift_sources():


This is outside the scope of what this script is meant for. This script updates current sources.. At this point you are getting into package management.. There are separate utils for this within swift.

bawangxx · 2015-12-04T04:48:51Z

很好很强大

gribozavr · 2015-12-04T06:23:51Z

@BrandonMathis Sorry, just noticed that the readme was updated to include both sets of instructions for both https and ssh access, and that your pull request changes it to use https only.

There are trade-offs between https and ssh. HTTPS is friendlier for people who don't have a github account. Using ssh by default optimizes for the developers with commit access.

Do you think we could also add a --clone-via-ssh option? That way, we can accommodate all members of the community.

yurikoles · 2015-12-04T19:49:54Z

I suggest to leave ability to clone whole sources by the script behind some option like '--full' . One may want to simply download this script and execute it standalone.

practicalswift · 2015-12-07T22:26:30Z

utils/update-checkout

@@ -16,6 +16,7 @@ from __future__ import print_function
 import argparse
 import os
 import sys
+import pdb


pdb needed? :-)

nope, nice catch :)

BrandonMathis · 2015-12-08T20:28:44Z

@gribozavr, support for cloaning via ssh has been added via a --clone-with-ssh argument. 👍

Simplify obtaining of swift sources

gribozavr · 2015-12-11T00:58:56Z

Thanks, @BrandonMathis!

BrandonMathis · 2015-12-12T23:21:22Z

Can do @gottesmm 😬👍🏼

Cleanup test status

* [WASM] Disable mmap test case for WASI OS due to lack of WASI API * [WASM] Disable simd test case for WASI OS simd api maybe stable in future https://github.com/WebAssembly/simd * [WASM] Fix to build pthread pollyfill only when wasi sdk * [WASM] Implement parsing command line arguments * [WASM] Run StdlibUnittest in process instead of child proc

[pull] swiftwasm from apple:master

BrandonMathis added 2 commits December 3, 2015 12:40

Simplify obtaining of swift sources

176d903

Correct interpriter

77ec422

kylef reviewed Dec 3, 2015
View reviewed changes

Favor https over ssh for cloning from github

665b08b

BrandonMathis mentioned this pull request Dec 3, 2015

Use https instead of git@ for cloning instructions #29

Closed

BrandonMathis added 3 commits December 3, 2015 18:33

Move additional repo cloning into the update-checkout py script

74a1d05

Update readme

e84acea

Specificity

2a1364d

gribozavr reviewed Dec 3, 2015
View reviewed changes

rootedbox reviewed Dec 3, 2015
View reviewed changes

Make changes per @gribozavr suggestions

2942c32

Merge branch 'master' into feature/easier-install

26508ca

Merge branch 'master' into feature/easier-install

9311f72

practicalswift reviewed Dec 7, 2015
View reviewed changes

BrandonMathis added 3 commits December 8, 2015 15:23

Added option install with ssh param

b0c4fbd

Uncomment update_working_copy code

f9bc59b

Remove extraneous newline

1b5ec13

Merge branch 'master' into feature/easier-install

dd68e72

gribozavr added a commit that referenced this pull request Dec 11, 2015

Merge pull request #31 from BrandonMathis/feature/easier-install

5d3fe25

Simplify obtaining of swift sources

gribozavr merged commit 5d3fe25 into swiftlang:master Dec 11, 2015

slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018

Merge pull request swiftlang#31 from seabaylea/test-status

4f8a3a9

Cleanup test status

davezarzycki mentioned this pull request Mar 10, 2020

[semantic-arc-opts] Implement @owned phi web elimination for phi webs with a single phi node that only have copy_value introducers. #30289

Merged

MaxDesiatov pushed a commit to MaxDesiatov/swift that referenced this pull request May 1, 2020

Merge pull request swiftlang#31 from apple/master

d1bc17c

[pull] swiftwasm from apple:master

swift-ci mentioned this pull request Apr 6, 2016

[SR-815] Generic classes with default property initializers bug #43427

Closed

jopamer mentioned this pull request May 18, 2016

[SR-1551] Compilation stuck instead of failing on misspelt property name #44160

Closed

ole mentioned this pull request Apr 25, 2022

[SR-6699] Swift Compiler allows invisible Unicode characters in identifiers #49248

Open

swift-ci mentioned this pull request Apr 25, 2022

[SR-15940] Assert crash in TypeCheckStmt.cpp #58201

Open

lhames mentioned this pull request Apr 14, 2023

[Immediate] Use the large code model #64720

Open

finagolfin mentioned this pull request Apr 25, 2022

[SR-16046] A test from NIO segfaults on Android armv7 when cross-compiled with the official Swift 5.6 release for Ubuntu 20.04 x86_64 #58307

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify obtaining of swift sources #31

Simplify obtaining of swift sources #31

BrandonMathis commented Dec 3, 2015

kylef Dec 3, 2015

XBeg9 commented Dec 3, 2015

stuarthannig commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

Leandros commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

jetpacmonkey commented Dec 3, 2015

jsjohnst commented Dec 3, 2015

davidcelis commented Dec 3, 2015

Leandros commented Dec 3, 2015

LinusU commented Dec 3, 2015

rootedbox commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

gribozavr commented Dec 3, 2015

yurikoles commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

wadestuart commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

jsjohnst commented Dec 3, 2015

gribozavr Dec 3, 2015

jsjohnst Dec 3, 2015

jsjohnst commented Dec 3, 2015

rootedbox Dec 3, 2015

bawangxx commented Dec 4, 2015

gribozavr commented Dec 4, 2015

yurikoles commented Dec 4, 2015

practicalswift Dec 7, 2015

BrandonMathis Dec 8, 2015

BrandonMathis commented Dec 8, 2015

gribozavr commented Dec 11, 2015

BrandonMathis commented Dec 12, 2015

		@@ -0,0 +1,11 @@
		#!/usr/env bash

		git clone git@github.com:apple/swift.git swift

Simplify obtaining of swift sources #31

Simplify obtaining of swift sources #31

Conversation

BrandonMathis commented Dec 3, 2015

kylef Dec 3, 2015

Choose a reason for hiding this comment

XBeg9 commented Dec 3, 2015

stuarthannig commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

Leandros commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

jetpacmonkey commented Dec 3, 2015

jsjohnst commented Dec 3, 2015

davidcelis commented Dec 3, 2015

Leandros commented Dec 3, 2015

LinusU commented Dec 3, 2015

rootedbox commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

gribozavr commented Dec 3, 2015

yurikoles commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

wadestuart commented Dec 3, 2015

BrandonMathis commented Dec 3, 2015

jsjohnst commented Dec 3, 2015

gribozavr Dec 3, 2015

Choose a reason for hiding this comment

jsjohnst Dec 3, 2015

Choose a reason for hiding this comment

jsjohnst commented Dec 3, 2015

rootedbox Dec 3, 2015

Choose a reason for hiding this comment

bawangxx commented Dec 4, 2015

gribozavr commented Dec 4, 2015

yurikoles commented Dec 4, 2015

practicalswift Dec 7, 2015

Choose a reason for hiding this comment

BrandonMathis Dec 8, 2015

Choose a reason for hiding this comment

BrandonMathis commented Dec 8, 2015

gribozavr commented Dec 11, 2015

BrandonMathis commented Dec 12, 2015