Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] avoid use generator expression to add linker parameter #29636

Merged
merged 2 commits into from
Feb 5, 2020
Merged

[build] avoid use generator expression to add linker parameter #29636

merged 2 commits into from
Feb 5, 2020

Commits on Feb 4, 2020

  1. [build] avoid use generator expression to add linker parameter 

    Generator expressions seem not to allow the `LINKER:` prefix to be
expanded correctly when used in `target_link_options`.

To solve this, undo the change from swiftlang#29451 and instead
use an `if` statement to add the flag when needed.

Addresses rdar://problem/59117166
    @edymtt
    edymtt committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    c60c69c View commit details
    Browse the repository at this point in the history

  2. Account for two code paths according to CMake version

    @edymtt
    edymtt committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    e438ce7 View commit details
    Browse the repository at this point in the history