Add support to create xctoolchain with code sign #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -595,3 +595,9 @@ installable-package=%(installable_package)s | |||
|
|
|||
| # Path to the .tar.gz symbols package | |||
| symbols-package=%(symbols_package)s | |||
|
|
|||
| # Info.plist | |||
| darwin-toolchain-bundle-identifier=%(toolchain_bundle_identifier)s | |||
There was a problem hiding this comment.
Could you prefix the %() variables with darwin_ as well?
|
Mostly stylistic comments. Over to you. |
- Add darwin_ prefix to preset variables - Add license header to utils/toolchain-codesign and utils/toolchain-installer - Simplify the logic to remove Info.plist
|
Updated the code with above review comments. |
| @@ -2114,6 +2122,36 @@ if [[ "${INSTALLABLE_PACKAGE}" ]] ; then | |||
| echo "--- Copy swift-stdlib-tool ---" | |||
| cp "${SWIFT_SOURCE_DIR}/utils/swift-stdlib-tool-substitute" "${INSTALL_DESTDIR}/${INSTALL_PREFIX}/bin/swift-stdlib-tool" | |||
| fi | |||
|
|
|||
| # Create plist for xctoolchain | |||
|
Please merge after fixing that one thing. |
shahmishal
added a commit
that referenced
this pull request
Nov 24, 2015
Add support to create xctoolchain with code sign
1 task
marcrasi
pushed a commit
that referenced
this pull request
Jun 14, 2018
…wift (#12) calling convention, where arguments are passed in as @guaranteed (+0) instead of @owned (+1). As such, the changes to the TFPartition pass are: 1. When sinking a special instruction foo(%x) (tf_send, tf_receive, tf_get_scalar_or_die) below tensor end point, where %x is a tensor handle, make sure we keep a strong_retain in its original inst position, and sink I along with a strong_release below tensor end point. Example code snippet: %x = ... foo(%x) ... <tensor end point> strong_release %x The transformed code after sinking foo(%x) is: %x = ... strong_retain %x ... <tensor end point> foo(%x) strong_release %x strong_release %x 2. When removing a copy marker inst (tf_send, tf_receive) from the host code, add a strong_retain to balance the refcount. Example code snippet: %x = ... %y = tf_send(%x) strong_release %y strong_release %x The transformed code after sinking foo(%x) is: %x = ... strong_retain %x strong_release %x strong_release %x 3. Also addressed Richard's code formatting suggestions in a previous PR.
marcrasi
pushed a commit
that referenced
this pull request
Jun 22, 2018
…wift (#12) calling convention, where arguments are passed in as @guaranteed (+0) instead of @owned (+1). As such, the changes to the TFPartition pass are: 1. When sinking a special instruction foo(%x) (tf_send, tf_receive, tf_get_scalar_or_die) below tensor end point, where %x is a tensor handle, make sure we keep a strong_retain in its original inst position, and sink I along with a strong_release below tensor end point. Example code snippet: %x = ... foo(%x) ... <tensor end point> strong_release %x The transformed code after sinking foo(%x) is: %x = ... strong_retain %x ... <tensor end point> foo(%x) strong_release %x strong_release %x 2. When removing a copy marker inst (tf_send, tf_receive) from the host code, add a strong_retain to balance the refcount. Example code snippet: %x = ... %y = tf_send(%x) strong_release %y strong_release %x The transformed code after sinking foo(%x) is: %x = ... strong_retain %x strong_release %x strong_release %x 3. Also addressed Richard's code formatting suggestions in a previous PR.
marcrasi
pushed a commit
that referenced
this pull request
Jun 28, 2018
…wift (#12) calling convention, where arguments are passed in as @guaranteed (+0) instead of @owned (+1). As such, the changes to the TFPartition pass are: 1. When sinking a special instruction foo(%x) (tf_send, tf_receive, tf_get_scalar_or_die) below tensor end point, where %x is a tensor handle, make sure we keep a strong_retain in its original inst position, and sink I along with a strong_release below tensor end point. Example code snippet: %x = ... foo(%x) ... <tensor end point> strong_release %x The transformed code after sinking foo(%x) is: %x = ... strong_retain %x ... <tensor end point> foo(%x) strong_release %x strong_release %x 2. When removing a copy marker inst (tf_send, tf_receive) from the host code, add a strong_retain to balance the refcount. Example code snippet: %x = ... %y = tf_send(%x) strong_release %y strong_release %x The transformed code after sinking foo(%x) is: %x = ... strong_retain %x strong_release %x strong_release %x 3. Also addressed Richard's code formatting suggestions in a previous PR.
lorentey
pushed a commit
that referenced
this pull request
Dec 11, 2019
This was referenced Jul 31, 2016
This was referenced Oct 4, 2022
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
Windows: correct typo of distributed for import libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to create code signed xctoolchain and installer pkg from
build-script.