ABI checker: removing deprecated APIs should be considered acceptable

swiftlang · Oct 20, 2021 · 819e53e · 819e53e
1 parent bab9189
commit 819e53e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/DriverTool/swift_api_digester_main.cpp b/lib/DriverTool/swift_api_digester_main.cpp
@@ -553,7 +553,10 @@ static void diagnoseRemovedDecl(const SDKNodeDecl *D) {
     if (D->hasDeclAttribute(DeclAttrKind::DAK_AlwaysEmitIntoClient))
       return;
   }
-  D->emitDiag(SourceLoc(), diag::removed_decl, D->isDeprecated());
+  // Don't diagnose removal of deprecated APIs.
+  if (!D->isDeprecated()) {
+    D->emitDiag(SourceLoc(), diag::removed_decl, false);
+  }
 }
 
 // This is first pass on two given SDKNode trees. This pass removes the common part

diff --git a/test/api-digester/stability-concurrency-abi.test b/test/api-digester/stability-concurrency-abi.test
@@ -116,7 +116,6 @@ Struct TaskGroup has generic signature change from <ChildTaskResult> to <ChildTa
 Struct TaskGroup.Iterator has generic signature change from <ChildTaskResult> to <ChildTaskResult where ChildTaskResult : Swift.Sendable>
 Struct ThrowingTaskGroup has generic signature change from <ChildTaskResult, Failure where Failure : Swift.Error> to <ChildTaskResult, Failure where ChildTaskResult : Swift.Sendable, Failure : Swift.Error>
 Struct ThrowingTaskGroup.Iterator has generic signature change from <ChildTaskResult, Failure where Failure : Swift.Error> to <ChildTaskResult, Failure where ChildTaskResult : Swift.Sendable, Failure : Swift.Error>
-Struct YieldingContinuation has been removed (deprecated)
 Subscript TaskLocal.subscript(_enclosingInstance:wrapped:storage:) has been removed
 Var UnownedJob.context has mangled name changing from 'Swift.UnownedJob.(context in #UNSTABLE ID#) : Builtin.Job' to 'Swift.UnownedJob.(context in #UNSTABLE ID#) : Builtin.Job'
 // *** DO NOT DISABLE OR XFAIL THIS TEST. *** (See comment above.)