-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AliasAnalysis] Remove the default argument from getMemoryBehavior.
ObserveRetains is not an obvious default and it does not make sense to have it as a default argument.
- Loading branch information
Showing
1 changed file
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b2da0a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not an obvious default? We want by default for computeMemoryBehavior to be conservative (i.e. not ignore retains) and for people to not have to reason about retains. If someone wants to do something more aggressive, they should have to think about it. Perhaps this enum has a poorly chosen name/case name?