Prevent Unrelated Casts on Child Choice Node

[Matejkob]

Resolves part of #2092

[ahoppen]

Hmm, this does significantly reduce the readability in many cases. I didn’t consider that you couldn’t easily chain if case…

After reading this, I think I changed my mind and we should offer non-deprecated casting methods to any option that the SyntaxChildChoices can have. And if one of that option is a base kind like DeclSyntax, we should offer a casting method to any DeclSyntaxProtocol.

[Matejkob]

Hmm, this does significantly reduce the readability in many cases. I didn’t consider that you couldn’t easily chain if case…

I completely agree. That was my main concern with value binding in the first place. I haven't yet found the time to go through this pitch: https://forums.swift.org/t/pitch-is-case-expressions/64185, so I'm not sure why it hasn't gone through yet. The issue definitely should be addressed—it's a day-to-day problem for many folks.

After reading this, I think I changed my mind and we should offer non-deprecated casting methods to any option that the SyntaxChildChoices can have. And if one of that option is a base kind like DeclSyntax, we should offer a casting method to any DeclSyntaxProtocol.

Sounds good to me. I'll try cook something

[ahoppen]

so I'm not sure why it hasn't gone through yet. The issue definitely should be addressed—it's a day-to-day problem for many folks.

I haven’t read the pitch completely either but I would imagine it’s just a matter of someone writing the official proposal and creating an implementation for it.

[Matejkob]

Base on last John's post https://forums.swift.org/t/pitch-is-case-expressions/64185/69 the whole pitch is abandoned 😢

[Matejkob]

@ahoppen how about now? Usage is cleaner, but there is plenty of code more on the implementation part :/

[ahoppen]

Looks good to me in general

[ahoppen]

@swift-ci Please test

[kimdv]

@swift-ci please test windows

[ahoppen]

@swift-ci Please test Windows