Split FunctionParameterSyntax and related types #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-stress-tester
that referenced
this pull request
Mar 28, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
This was referenced Mar 28, 2023
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Mar 28, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Mar 28, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Mar 28, 2023
… nodes for function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Mar 28, 2023
…ultiple nodes for function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
force-pushed
the
ahoppen/split-function-parameter
branch
from
c9a3785
to
9f9f53b
Compare
ahoppen
force-pushed
the
ahoppen/split-function-parameter
branch
from
9f9f53b
to
33d4ce3
Compare
|
swiftlang/swift#64697 @swift-ci Please test Windows |
ahoppen
force-pushed
the
ahoppen/split-function-parameter
branch
from
33d4ce3
to
89d5d32
Compare
ahoppen
force-pushed
the
ahoppen/split-function-parameter
branch
from
89d5d32
to
1621138
Compare
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Mar 30, 2023
…ultiple nodes for function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Mar 31, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Mar 31, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
|
swiftlang/swift#64697 @swift-ci Please test Windows |
bnbarham
reviewed
Mar 31, 2023
Sources/SwiftParser/Parameters.swift
Outdated
| // MARK: Parameter parsing | ||
|
|
||
| extension Parser { | ||
| mutating func parseFunctionParameter() -> RawFunctionParameterSyntax { |
There was a problem hiding this comment.
There's a fair bit of duplication between these. Did you find that made more sense then having options on a parseParameterLikeDecl(...) sort of function? RawParameterTrait could include an init that just has alllll the things, where we ignore params that don't make sense where necessary.
There was a problem hiding this comment.
I wanted to get the compile-time safety of not forgetting to pass one of the required arguments and I think we can only reasonably to do was to duplicate it.
There was a problem hiding this comment.
You can still have separate parseFunctionParameter etc. for callers outside. It'd just be fileprivate within Parameters.
Comment on lines
-736
to
-737
| nameForDiagnostics: "type", | ||
| isOptional: true |
FunctionParameterSyntax was used in a number of cases (function parameter, closure parameter and enum case parameter) and because it needs to satisfy all of them all its parameters are optional. Split it into three different types that have non-optional children. rdar://106874808
ahoppen
force-pushed
the
ahoppen/split-function-parameter
branch
from
1621138
to
fe710b2
Compare
1 similar comment
|
swiftlang/swift#64697 @swift-ci Please test Windows |
bnbarham
approved these changes
Apr 5, 2023
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Apr 5, 2023
…ultiple nodes for function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to swiftlang/swift-format
that referenced
this pull request
Apr 5, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to swiftlang/swift-stress-tester
that referenced
this pull request
Apr 5, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
ahoppen
added a commit
to swiftlang/swift-format
that referenced
this pull request
Apr 5, 2023
…r function parameters, closure parameters and enum parameters Companion of swiftlang/swift-syntax#1455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionParameterSyntax was used in a number of cases (function parameter, closure parameter and enum case parameter) and because it needs to satisfy all of them all its parameters are optional. Split it into three different types that have non-optional children.
rdar://106874808