Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Implement --checksum option on swift sdk install #7723

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Jun 27, 2024

Cherry-pick of #7722.

Explanation: This option was specified in the corresponding proposal for Swift SDKs:

For Swift SDKs installed from remote URLs an additional --checksum option is required, through which users of a Swift SDK can specify a checksum provided by a publisher of the SDK. The latter can produce a checksum by running swift package compute-checksum command (introduced in SE-0272) with the Swift SDK bundle archive as an argument.

Scope: the change is isolated to swift sdk install and swift package compute-checksum subcommands.
Risk: low due to isolation to only two rarely used subcommands with corresponding automated test cases provided.
Testing: updated existing test cases.
Issue: rdar://130590711
Reviewer: @bnbarham

This option [was specified in the corresponding proposal for Swift SDKs](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md#swift-sdk-installation-and-configuration):

> For Swift SDKs installed from remote URLs an additional `--checksum` option is required, through which users of a Swift SDK can specify a checksum provided by a publisher of the SDK. The latter can produce a checksum by running `swift package compute-checksum command` (introduced in [SE-0272](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0272-swiftpm-binary-dependencies.md)) with the Swift SDK bundle archive as an argument.

# Conflicts:
#	Sources/SwiftSDKCommand/InstallSwiftSDK.swift
#	Sources/SwiftSDKCommand/ListSwiftSDKs.swift
#	Sources/SwiftSDKCommand/SwiftSDKCommand.swift
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov removed their assignment Jun 27, 2024
MaxDesiatov added a commit that referenced this pull request Jul 3, 2024
Cherry-pick of
#7748.

**Explanation**: This feature [was specified in the corresponding
proposal for Swift
SDKs](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md#swift-sdk-installation-and-configuration):

> For Swift SDKs installed from remote URLs an additional `--checksum`
option is required, through which users of a Swift SDK can specify a
checksum provided by a publisher of the SDK. The latter can produce a
checksum by running `swift package compute-checksum` command (introduced
in
[SE-0272](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0272-swiftpm-binary-dependencies.md))
with the Swift SDK bundle archive as an argument.

Currently, `swift package compute-checksum` is unable to handle
`.tar.gz` bundles, which is a commonly used format for Swift SDKs. We're
fixing that here by adding correct and unified handling for archive
extensions.

This change is isolated to the `swift package compute-checksum`
subcommand. The `--checksum` option is added in a subsequent PR:
#7722.

**Scope**: Isolated to `swift package compute-checksum` subcommand.
**Risk**: Low, no existing behavior is 
**Testing**: Automated test cases modified/added and passing in a
subsequent PR:
#7723
**Issue**: rdar://130590711
**Reviewer**: @bnbarham
(cherry picked from commit b4ed2d0)
(cherry picked from commit 8d9231a)

# Conflicts:
#	Sources/PackageModel/SwiftSDKs/SwiftSDK.swift
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) July 26, 2024 16:26
@MaxDesiatov MaxDesiatov merged commit 5b27e1a into release/6.0 Jul 26, 2024
5 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/checksum-swift-sdk-6.0 branch July 26, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants