[Test] Relax ordering assumption in max-commands-progress.ninja #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While most of the times `output-2` is copied before `output-1`, in some rare cases the opposite can happen (which seems reasonable since there are not ordering between the two). Addresses rdar://72898516
|
@swift-ci please smoke test |
|
My change as is would consider the following valid but I think the main focus of those checks is comparing the ordering between the |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test |
dmbryson
approved these changes
Feb 1, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most of the times
output-2is copied beforeoutput-1, in somerare cases the opposite can happen (which seems reasonable since there
is no ordering requirement between the two).
Addresses rdar://72898516