Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for integer generics with new generic argument node #866

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Azoy
Copy link

@Azoy Azoy commented Oct 25, 2024

With swiftlang/swift-syntax#2859, there will be a new generic argument node that you need to switch over.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the CI failures for now, we need to figure out how to support cross-PR testing, swift-format will get tested as part of your test invocation from swiftlang/swift-syntax#2859. We just need to coordinate merging the PRs because bypassing the CI on this PR requires force-merge capabilities.

But please address the format issues found by https://github.com/swiftlang/swift-format/actions/runs/11524662613/job/32085325124?pr=866

Sources/SwiftFormat/Rules/UseShorthandTypeNames.swift Outdated Show resolved Hide resolved
Sources/SwiftFormat/Rules/UseShorthandTypeNames.swift Outdated Show resolved Hide resolved
Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably also need to make some changes in TokenStreamCreator to make sure that parameter declarations like struct S<let T: Int> (or however it's spelled) get correct whitespace/line-wrapping behavior.

Unfortunately we don't have a good way for the formatter to pass experimental features down to the parser, so that might have to wait. For now, this seems fine (with @ahoppen 's suggested changes) to prevent CI failures from the breaking API change, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants