New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.0] Fix missing break in nested IfConfig decls #782

Merged

ahoppen merged 1 commit into swiftlang:release/6.0 from ahoppen:6.0/fix-nested-if-config-statements

Jul 26, 2024

Member

ahoppen commented Jul 26, 2024

Explanation: Forces #endif to always be followed by a newline, fixing incorrect formatting that could put #endif and a following #if on the same line
Scope: Formatting of If config declarations
Risk: Very narrow fix
Testing: Added test case
Issue: rdar://132365692, swift-format bug formatting nested #if #else #endif nodes in switch statement #779
Reviewer: @ahoppen


          Fix missing break in nested IfConfig decls. Fixes swiftlang#779.

6b33c66

ahoppen requested a review from bnbarham

July 26, 2024 18:24

ahoppen mentioned this pull request

Dummy PR 2 for CI testing in swift-format swiftlang/swift-syntax#2756

Draft

bnbarham approved these changes

View reviewed changes

ahoppen merged commit 58f07e3 into swiftlang:release/6.0

ahoppen deleted the 6.0/fix-nested-if-config-statements branch

July 26, 2024 22:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet