[6.0] Update links for repositories moved to the swiftlang org on GitHub #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
approved these changes
Jun 25, 2024
CMakeLists.txt
Outdated
| @@ -68,7 +68,7 @@ endif() | |||
| find_package(SwiftSyntax CONFIG) | |||
| if(NOT SwiftSyntax_FOUND) | |||
| FetchContent_Declare(Syntax | |||
| GIT_REPOSITORY https://github.com/apple/swift-syntax | |||
| GIT_REPOSITORY https://github.com/swiftlang/swift-syntax | |||
| GIT_TAG main) | |||
There was a problem hiding this comment.
Unrelated to this PR, but I just noticed that CMake is referring to the main branch here. Does that need to be fixed on the 6.0 branch?
There was a problem hiding this comment.
Heh, probably. It wouldn't be used in CI at all. @compnerd what if instead of specifying repository + tag, we just specify a path that's passed down and then rely on update-checkout? It makes it a little more clunky to eg. just build the repo itself, but is maybe better than having yet another place to update versions?
There was a problem hiding this comment.
I updated the branch to release/6.0 for now. But yes, would be nice to not have yet another place that needs version updates.
ahoppen
force-pushed
the
6.0/swiftlang-migration
branch
from
7ca401c to
7200769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.