Various fixes for some 509.0.0 bugs. #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refine the treatment of the closing bracket so that it is only forced to go onto a new line if the subscript component is not the last component in the keypath. This aligns with how we handle closing brackets/parentheses in member access chains. Fixes swiftlang#663.
…ain comments. Fixes swiftlang#665.
Like with `some/any` type sugar, when we simplify an `Optional` whose type parameter is an attributed type, we need to wrap it in parentheses so that the `?` doesn't bind with the contained type. Fixes swiftlang#657.
|
CI came back green. Will need to wait until the holiday freeze is over to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseShorthandTypeNames(fixes UseShorthandTypeNames incorrect with Sendable functions #657).NoEmptyTrailingClosureParentheses(fixes 509 Regression: swift-format is deleting comments #665).