Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AllPublicDeclarationsHaveDocumentation] Fix behavior for override methods. #655

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

allevato
Copy link
Member

This was mistakenly broken during a refactor and we didn't have test coverage for it. We didn't have test coverage for it because the tests behave differently than the rule does when executed in the whole pipeline, so we need to fix that too. I'm going to do that in a separate PR, because it might have knock-on effects elsewhere.

Fixes #651.

…methods.

This was mistakenly broken during a refactor and we didn't have test coverage
for it. We didn't have test coverage for it because the tests behave
differently than the rule does when executed in the whole pipeline, so we
need to fix that too. I'm going to do that in a separate PR, because it
might have knock-on effects elsewhere.

Fixes swiftlang#651.
@allevato allevato merged commit b2d25c6 into swiftlang:main Oct 19, 2023
@allevato allevato deleted the no-warn-overrides branch October 19, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AllPublicDeclarationsHaveDocumentation warns on overridden methods
1 participant