Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encode an explicit null for DownloadReference's checksum #656

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Bug/issue #, if applicable: rdar://111865266

Summary

For ease of processing, this PR changes the DownloadReference's checksum property to encode an explicit null into its JSON when no checksum was provided.

Dependencies

None

Testing

Steps:

  1. DOCC_JSON_PRETTYPRINT=YES swift run docc convert --output-path .build/out.doccarchive 'Tests/SwiftDocCTests/Test Bundles/SampleBundle.docc'
  2. Inspect .build/out.doccarchive/data/documentation/samplebundle/relativeurlsample.json and ensure that the reference for "files/ExternalSample.zip" contains a "checksum" : null line.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • [ n/a ] Updated documentation if necessary

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@ethan-kusters ethan-kusters merged commit 3d6bc16 into swiftlang:main Jul 8, 2023
@QuietMisdreavus QuietMisdreavus deleted the explicit-null branch July 10, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants